🎨 Palette: Improve list-tasks output formatting and JSON support #504
Conversation
- Refactor `list-tasks` command to collect structured data before output - Implement valid JSON output for `list-tasks` when using `--output json` - Enhance text output with colors for better readability (Play names in Blue, Task names in Bold, Module names in Cyan) - Add unit test for PlayListing serialization - Fix issue where text output was interleaved with JSON structure This aligns with the Palette UX initiative to improve CLI scannability and structured output reliability. Co-authored-by: dolagoartur <146357947+dolagoartur@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 11fa5aa055
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Colored header: Play #1: Play Name | ||
| // We construct the string first to handle the formatting properly | ||
| println!("\n{} {}: {}", | ||
| "Play".blue().bold(), |
There was a problem hiding this comment.
The new human-readable rendering applies colored styles directly (e.g., .blue().bold()) without checking the formatter’s color setting, so rustible --no-color list-tasks ... can still emit ANSI escapes in interactive terminals. This regresses the CLI contract where CommandContext::new configures color behavior from !cli.no_color, and it affects users piping/logging output that must remain plain text.
Useful? React with 👍 / 👎.
adolago
deleted the
palette-list-tasks-improvements-18357645187385738565
branch
1 participant
Improved the
list-taskscommand to support proper JSON output and enhanced the text output with colors for better readability.Changes:
ListTasksArgs::executeinsrc/cli/commands/inventory.rsto gather data intoPlayListingandTaskListingstructs.serde_jsonoutput whenctx.output.is_json()is true.coloredoutput for human-readable mode, making it easier to distinguish plays, tasks, and modules.UX Improvements:
Verification:
cargo test --bin rustible cli::commands::inventory(all passed).PR created automatically by Jules for task 18357645187385738565 started by @dolagoartur