refactor: replace smpltmpl dependency with internal function #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test is failing on windows coz of the newline character. Mind fixing it? https://ci.appveyor.com/project/thetutlage/ace/builds/31990978/job/tahjb4piqfdjgioq |
smpltmpl depends on babel-code-frame, which, with its subdependencies adds about 10 unnecessary packages to the tree in production. Moreover, it interpolates the template by running it as code in a Node.js vm, which is not that simple, for a "simple" library. Replace it with a simple internal implementation.
|
Done! |
|
Looks rad! Thanks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smpltmpl depends on babel-code-frame, which, with its subdependencies
adds about 10 unnecessary packages to the tree in production.
Moreover, it interpolates the template by running it as code in a Node.js
vm, which is not that simple, for a "simple" library.
Replace it with a simple internal implementation.