Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack dev server not beeing killed by CTRL+C in Windows #26

Merged
merged 1 commit into from
May 8, 2021

Conversation

McSneaky
Copy link
Contributor

@McSneaky McSneaky commented May 6, 2021

Proposed changes

Killing server with CTRL-C in dev mode in Windows leaves webpack-dev-server running on port 8080 and
never releases it, making it impossible to start up again with node ace serve -w because port 8080 is already in use.

Have to use Get-Process -Id (Get-NetTCPConnection -LocalPort 8080).OwningProcess to find the proccess ID and then kill it with Stop-Process -ID ID_HERE -Force

Fixes adonisjs/core#2562

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

…C in Windows

Killing server with CTRL-C in dev mode in Windows leaves webpack-dev-server running on port 8080 and
never releases it

fix adonisjs/core#2562
@thetutlage thetutlage merged commit 232f1ad into adonisjs:develop May 8, 2021
@thetutlage
Copy link
Member

🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CTRL + C not killing webpack dev server in Windows cousing port 8080 to be locked
2 participants