Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default hasher mismatch fix #4005

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Conversation

arabbani
Copy link
Contributor

@arabbani arabbani commented Dec 7, 2022

Proposed changes

Changes the comment for default hasher.
Here it is saying inside the comment that argon is the default hasher. But the default prop is set to scrypt

Screenshot 2022-12-05 214059

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Further comments

@thetutlage thetutlage merged commit cbd734e into adonisjs:develop Feb 20, 2023
@thetutlage
Copy link
Member

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants