Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: add PATCH as a default method for CORS headers #4244

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

mr-feek
Copy link
Contributor

@mr-feek mr-feek commented Sep 5, 2023

Proposed changes

Hello 👋

Is there a specific reason that PATCH was not included as a default method for the CORS configuration? It took me a little bit of stumbling around to figure out why PATCH requests weren't working for me. It was surprising to me that this was not a default.

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply
(not positive here, since this is a template that would likely only affect new projects, I'm considering it a new feature).

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Further comments

The docs would need to be updated too if this change were to be accepted.

Co-authored-by: Romain Lanz <2793951+RomainLanz@users.noreply.github.com>
@RomainLanz RomainLanz merged commit b5f0606 into adonisjs:develop Sep 21, 2023
4 checks passed
@RomainLanz
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants