Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/handle no prefix #1

Merged
merged 5 commits into from
Nov 6, 2023
Merged

Conversation

Xstoudi
Copy link
Contributor

@Xstoudi Xstoudi commented Oct 14, 2023

πŸ”— Linked issue

https://github.com/adonisjs/road-to-v6/discussions/39

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Before the change, create-adonisjs was not handling --no- prefix on boolean flags, not allowing to force install and forge git init without prompt.

I'm working on a JetBrains plugin for Adonis and I would like to use officially supported create-adonis tool to initialize project.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@thetutlage
Copy link
Member

This test https://github.com/adonisjs/create-adonisjs/actions/runs/6620367349/job/17986024364?pr=1#step:6:43 seems to be failing, can you please look into it?

@Xstoudi
Copy link
Contributor Author

Xstoudi commented Oct 31, 2023

Test passes 😁

@thetutlage thetutlage merged commit ad60f1c into adonisjs:develop Nov 6, 2023
@thetutlage
Copy link
Member

Thanks for taking out time and working on the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants