Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formatter): zero triggering fallback return #39

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

seanc
Copy link
Contributor

@seanc seanc commented Dec 25, 2018

Proposed changes

This pull request fixes issue #38

When passing zero in formatNumber, it was considered falsey and triggered the fallback return statement resulting in a null return.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.918% when pulling f111616 on seanc:develop into 0b0eff2 on adonisjs:develop.

@RomainLanz RomainLanz merged commit e54c93f into adonisjs:develop Feb 7, 2019
@RomainLanz
Copy link
Member

Thanks! 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants