fix(QueryBuilder): support falsy values in between pairs (#556)

adonisjs · Jun 13, 2020 · 2d2e7cb · 2d2e7cb
1 parent ff9fb2e
commit 2d2e7cb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Database/QueryBuilder/Chainable.ts b/src/Database/QueryBuilder/Chainable.ts
@@ -54,7 +54,7 @@ export abstract class Chainable extends Macroable implements ChainableContract {
    */
   private getBetweenPair (value: any[]): any {
     const [lhs, rhs] = value
-    if (!lhs || !rhs) {
+    if (lhs === undefined || rhs === undefined) {
       throw new Error('Invalid array for whereBetween value')
     }
 

diff --git a/test/database/query-builder.spec.ts b/test/database/query-builder.spec.ts
@@ -2051,12 +2051,12 @@ test.group('Query Builder | whereBetween', (group) => {
     let db = getQueryBuilder(getQueryClient(connection))
     const { sql, bindings } = db
       .from('users')
-      .whereBetween('age', [18, 20])
+      .whereBetween('age', [0, 20])
       .toSQL()
 
     const { sql: knexSql, bindings: knexBindings } = connection.client!
       .from('users')
-      .whereBetween('age', [18, 20])
+      .whereBetween('age', [0, 20])
       .toSQL()
 
     assert.equal(sql, knexSql)