-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding options on refresh() method (Fixing issue #649) #650
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, can you please add tests for the changes you have made?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes updated.
This reverts commit 525c89e.
Co-authored-by: Romain Lanz <2793951+RomainLanz@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the typo of commit description, it should be no-shadow
please let me know if I should do any changes. |
Hey ! It seems that you added few changes that are not related to this PR, also, there's some conflicts, could you fix them? |
Yes,
|
Hello @urishabh11 Thanks for taking out time to work on the PR. The changes required a bit more code to make it work properly. To be precise, I have moved the refresh logic to the |
That's great 👍 Waiting for the new release with the updates :-) |
Proposed changes
Fixing issue #649
Making refresh method use transaction.
Types of changes
Checklist