Update MakeModel.ts

[urishabh11]

Proposed changes

Bug fix on MakeModel, executing make:migration within same process so this can ask for "migration folder" in MakeMigration.

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• I have read the CONTRIBUTING doc
• Lint and unit tests pass locally with my changes
• [] I have added tests that prove my fix is effective or that my feature works.
• [] I have added necessary documentation (if appropriate)

Further comments

When there are multiple migration folder, MakeMigrations prompts for the directory. This gets breaks on background process.

[thetutlage]

A couple of issues.

• The make:migration needs access to the application, whereas make:model command is not enabling the loadApp: true. So it will basically break
• If execCommand is not used anymore, then it should be removed from the class.

Finally, the child process can inherit the stdio for prompts to work.

[thetutlage]

Okay. So I just looked at the source code closely. We should just get rid of execCommand method and just use the kernel.exec for both migration and the controller.

[urishabh11]

Thanks for the input, I've updated the file.

[thetutlage]

Thanks for the PR :)