Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate to the new Japa #803

Merged
merged 5 commits into from
Mar 3, 2022
Merged

Conversation

Julien-R44
Copy link
Member

  • Migration to the new Japa version
  • Close all connections that were left open in order to remove forceExit from Japa config
  • Fix bug where dropAllTables called on an empty MySQL database would throw an exception

However there is still a bug since the migration: only on MSSQL, the updated_at is not exactly equal to the created_at.
See the logs of the last CI:
image

Have you already seen this issue? Do I just add an assert.closeTo or do you think there is a real problem somewhere?

@thetutlage thetutlage merged commit cb15d56 into develop Mar 3, 2022
@thetutlage
Copy link
Member

Thanks 👍

@Julien-R44 Julien-R44 deleted the feat/japa-migration branch March 3, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants