Fix's a regression in ember-data >= 2.4.0 related to handleResponse changes #83
Conversation
…ng in RESTAdapter's handleResponse function emberjs/data#3930, pass along requestData as argument in active-model-adapter handleResponse override method as well as fix handleResponse - returns ajax response if not 422 response test
jcope2013
force-pushed
the
broken-handleResponse-tests-ember-data-2.4
branch
from
c10cd47 to
03e8c44
Compare
jcope2013
changed the title
| @@ -148,7 +148,7 @@ const ActiveModelAdapter = RESTAdapter.extend({ | |||
| @param {Object} payload | |||
| @return {Object | DS.AdapterError} response | |||
| */ | |||
| handleResponse: function(status, headers, payload) { | |||
| handleResponse: function(status, headers, payload, requestData) { | |||
There was a problem hiding this comment.
requestData isn't used within the method, so I wonder if we should update .jshintrc's setting for unused to change it from "vars" to true so JSHint errors for unused arguments too...
There was a problem hiding this comment.
I disagree, I think unused: true is a really annoying setting. We often copy/paste from documentation as developers, and the unused argument gets minified out anyway.
There was a problem hiding this comment.
Ok, that is a good point.
|
Apart from my tiny nitpick about the not used argument this looks good, thanks @jcope2013 |
|
This bug is super annoying. The empty tests that are generated with a new model no longer pass. ETA on this PR? |
|
friendly pinging @fivetanley @bmac: can you take a look and merge if this looks good to you? I am 👍 on this. |
Fix's a regression in ember-data >= 2.4.0 related to arguments changing in RESTAdapter's handleResponse function emberjs/data#3930, pass along requestData as argument in active-model-adapter handleResponse override method as well as fix handleResponse - returns ajax response if not 422 response test
closes #82