Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use deepSet when updating RUNNING_VALIDATIONS for nested key #328

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Use deepSet when updating RUNNING_VALIDATIONS for nested key #328

merged 1 commit into from
Dec 11, 2018

Conversation

SergeAstapov
Copy link
Contributor

@SergeAstapov SergeAstapov commented Nov 22, 2018

When ember-changeset is used for complex objects with nested keys in combination with ember-cp-validations (via ember-changeset-cp-validations) changes to nested keys produce an error Property set failed: object in path "person" could not be found or was destroyed.

Reproduction can be found at https://9j9o487k3o.sse.codesandbox.io/ (open console and click on checkbox).

Changes proposed in this pull request

Use deepSet instead of set to support nested keys.

@SergeAstapov
Copy link
Contributor Author

Build fails in beta with error

dummy/tests/integration/components/changeset-test.js: Assertion Failed: Cannot invoke the `changeset` helper because it was shadowed by a local variable (i.e. a block param) with the same name. Please rename the local variable to resolve the conflict. (L2:C14) 

That assertion was introduced in emberjs/ember.js#17132.

Fixed in #329

@SergeAstapov
Copy link
Contributor Author

@snewcomer I see there is large work happens in #317 and #327 (which is awesome!).
Meanwhile can this be releases as patch version? Is there anything I can help to push this and #330 forward?

@snewcomer
Copy link
Collaborator

Yeah of course :). Will review by early next week. Need to figure out what to pull into 2.0 and what to fix directly!

@snewcomer snewcomer merged commit d869623 into adopted-ember-addons:master Dec 11, 2018
@snewcomer
Copy link
Collaborator

Published 1.6.0! Thanks @SergeAstapov. Will add note however, that many users may want to stay on 1.3.0. It depends on their use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants