Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't work with yarn workspaces #88

Closed
shamcode opened this issue Sep 5, 2018 · 0 comments · Fixed by #89
Closed

Don't work with yarn workspaces #88

shamcode opened this issue Sep 5, 2018 · 0 comments · Fixed by #89

Comments

@shamcode
Copy link
Contributor

shamcode commented Sep 5, 2018

Don't work with yarn workspaces:

=================================================================================
ERROR Summary:

  - broccoliBuilderErrorStack: Error: ENOENT: no such file or directory, open '/home/sham/work/ember-cli-hot-loader-with-yarn-worspaces/ember-app/tmp/node_modules/ember-source/dist/ember-template-compiler.js'
    at Object.fs.openSync (fs.js:646:18)
    at Object.fs.readFileSync (fs.js:551:33)
    at SourceMap.addFile (/home/sham/work/ember-cli-hot-loader-with-yarn-worspaces/node_modules/fast-sourcemap-concat/lib/source-map.js:77:33)
    at headerFiles.forEach.file (/home/sham/work/ember-cli-hot-loader-with-yarn-worspaces/node_modules/broccoli-concat/concat.js:201:18)
    at Array.forEach (<anonymous>)
    at Concat.concat.end.concat (/home/sham/work/ember-cli-hot-loader-with-yarn-worspaces/node_modules/broccoli-concat/concat.js:199:26)
    at /home/sham/work/ember-cli-hot-loader-with-yarn-worspaces/node_modules/fast-sourcemap-concat/lib/source-map.js:431:14
    at new Promise (<anonymous>)
    at SourceMap.end (/home/sham/work/ember-cli-hot-loader-with-yarn-worspaces/node_modules/fast-sourcemap-concat/lib/source-map.js:418:12)
    at Concat._doLegacyBuild (/home/sham/work/ember-cli-hot-loader-with-yarn-worspaces/node_modules/broccoli-concat/concat.js:184:24)
  - codeFrame: ENOENT: no such file or directory, open '/home/sham/work/ember-cli-hot-loader-with-yarn-worspaces/ember-app/tmp/node_modules/ember-source/dist/ember-template-compiler.js'
  - errorMessage: Build Canceled: Broccoli Builder ran into an error with `SourceMapConcat` plugin. 💥
ENOENT: no such file or directory, open '/home/sham/work/ember-cli-hot-loader-with-yarn-worspaces/ember-app/tmp/node_modules/ember-source/dist/ember-template-compiler.js'
  - errorType: Build Error
  - location:
    - column: [undefined]
    - file: [undefined]
    - line: [undefined]
    - treeDir: [undefined]
  - message: Build Canceled: Broccoli Builder ran into an error with `SourceMapConcat` plugin. 💥
ENOENT: no such file or directory, open '/home/sham/work/ember-cli-hot-loader-with-yarn-worspaces/ember-app/tmp/node_modules/ember-source/dist/ember-template-compiler.js'
  - name: Error
  - nodeAnnotation: Vendor JS
  - nodeName: SourceMapConcat
  - originalErrorMessage: ENOENT: no such file or directory, open '/home/sham/work/ember-cli-hot-loader-with-yarn-worspaces/ember-app/tmp/node_modules/ember-source/dist/ember-template-compiler.js'
  - stack: Error: ENOENT: no such file or directory, open '/home/sham/work/ember-cli-hot-loader-with-yarn-worspaces/ember-app/tmp/node_modules/ember-source/dist/ember-template-compiler.js'
    at Object.fs.openSync (fs.js:646:18)
    at Object.fs.readFileSync (fs.js:551:33)
    at SourceMap.addFile (/home/sham/work/ember-cli-hot-loader-with-yarn-worspaces/node_modules/fast-sourcemap-concat/lib/source-map.js:77:33)
    at headerFiles.forEach.file (/home/sham/work/ember-cli-hot-loader-with-yarn-worspaces/node_modules/broccoli-concat/concat.js:201:18)
    at Array.forEach (<anonymous>)
    at Concat.concat.end.concat (/home/sham/work/ember-cli-hot-loader-with-yarn-worspaces/node_modules/broccoli-concat/concat.js:199:26)
    at /home/sham/work/ember-cli-hot-loader-with-yarn-worspaces/node_modules/fast-sourcemap-concat/lib/source-map.js:431:14
    at new Promise (<anonymous>)
    at SourceMap.end (/home/sham/work/ember-cli-hot-loader-with-yarn-worspaces/node_modules/fast-sourcemap-concat/lib/source-map.js:418:12)
    at Concat._doLegacyBuild (/home/sham/work/ember-cli-hot-loader-with-yarn-worspaces/node_modules/broccoli-concat/concat.js:184:24)

=================================================================================

Repo for reproduce.
shamcode added a commit to shamcode/ember-cli-hot-loader that referenced this issue Sep 5, 2018
@shamcode
Do not use the relative path to ember-template-compiler for compatibi…
5f0c21e 
…lity with yarn workspaces (adopted-ember-addons#88)
@shamcode shamcode mentioned this issue Sep 5, 2018
Merged
@shamcode shamcode changed the title Dont't work with yarn workspaces Don't work with yarn workspaces Sep 5, 2018
@shamcode shamcode closed this as completed Sep 5, 2018
@shamcode shamcode reopened this Sep 5, 2018
shamcode added a commit to shamcode/ember-cli-hot-loader that referenced this issue Sep 5, 2018
@shamcode
Use require.resolve as fallback (adopted-ember-addons#88)
e7e1fba
shamcode added a commit to shamcode/ember-cli-hot-loader that referenced this issue Sep 7, 2018
@shamcode
Add addon options templateCompilerPath (adopted-ember-addons#88)
422d309
@toranb toranb closed this as completed in #89 Sep 7, 2018
lifeart pushed a commit to lifeart/ember-cli-hot-loader that referenced this issue Sep 10, 2018
@shamcode @lifeart
Add addon options templateCompilerPath (adopted-ember-addons#88)
40b2ae8
lifeart added a commit to lifeart/ember-cli-hot-loader that referenced this issue Sep 11, 2018
@lifeart
Revert "Add addon options templateCompilerPath (adopted-ember-addon…
6e6c7e8 
…s#88)"

This reverts commit 40b2ae8.
lifeart added a commit to lifeart/ember-cli-hot-loader that referenced this issue Sep 11, 2018
@lifeart
Revert "Add addon options templateCompilerPath (adopted-ember-addon…
18b8214 
…s#88)"

This reverts commit 40b2ae8.
lifeart pushed a commit to lifeart/ember-cli-hot-loader that referenced this issue Sep 11, 2018
@shamcode @lifeart
Add addon options templateCompilerPath (adopted-ember-addons#88)
d460f9b
lifeart added a commit to lifeart/ember-cli-hot-loader that referenced this issue Sep 11, 2018
@lifeart
Revert "Add addon options templateCompilerPath (adopted-ember-addon…
78ea970 
…s#88)"

This reverts commit 40b2ae8.
lifeart pushed a commit to lifeart/ember-cli-hot-loader that referenced this issue Sep 11, 2018
@shamcode @lifeart
Add addon options templateCompilerPath (adopted-ember-addons#88)
f0cff9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

require.resolve fallback shamcode/ember-cli-hot-loader
1 participant
@shamcode