fix: apply included function with arguments instead of app #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the "recommended" way as seen in https://ember-cli.com/extending/#addon-entry-point . I'm opening this PR as `this._super.included(app)` it causes some issues with ember-decorators and the next ember-cli-typescript version. This will prevent others from having to dive in on why this happens if you try to port your addon to use these addons.
|
Thanks for the proactive work here! |
|
Published to npm as v1.4.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the "recommended" way as seen in https://ember-cli.com/extending/#addon-entry-point .
I'm opening this PR as
this._super.included(app)it causes some issues with ember-decorators and the next ember-cli-typescript version.This will prevent others from having to dive in on why this happens if you try to port your addon to use these addons.