Layout Template Markdown Demos #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
May 14, 2016 23:38
markdown property is computed off of the saved values generated ember-collection and the prototype layout
|
I'm curious what improvements could be made to the demo. I realize there are both documentation and demo changes in this PR. I believe a handful of ember developers could benefit from these layout template demos today. Please let me know some possible steps going forward. Thanks. |
|
Is this component still being actively developed? It seems there are a lot of unmerged PRs and no activities for a few months. Should I use this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Layout Markdown Demos show the parameters and results that ember-collection is passing and receiving to/from the layout templates. It has been extended to all layout types, so click the
Show Custom Layout Templatebutton on any Grid Demo to see interactions between ember-collection and the cell-layout template.Scroll-Position Layout Demo
Why add layout template demo?
The default grids are useful, but you may need to roll your own custom template solution. In this case it is helpful to know how ember-collection is using the layout templates. It took a couple of days to reverse-engineer the fixed layout template to really understand what ember-collection was doing. I created the Layout Demo to help bridge the knowledge gap for those who are also building their own custom templates.
Thanks to @lukemelia for his EmberNYC custom layout demo which made me attempt my own custom layout in the first place.
Note: This PR also includes README Updates