Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] Update to ember 3.4 and fix tests #182

Merged
merged 8 commits into from
May 12, 2020
Merged

[CHORE] Update to ember 3.4 and fix tests #182

merged 8 commits into from
May 12, 2020

Conversation

Gaurav0
Copy link
Contributor

@Gaurav0 Gaurav0 commented May 12, 2020 •
edited
Loading

Notes:

  1. New deprecations introduced in 3.x not fixed
  2. Dependencies not updated unless strictly necessary to fix build or done by ember-cli-update
  3. Test codemods run and tests updated to RFC-232 style
  4. Still requires jquery for now
  5. Have assumed addon still works, just tests don't. Recommend testing in actual apps.

@Alonski Alonski requested a review from RobbieTheWagner May 12, 2020 07:22
@Alonski
Copy link
Member

Alonski commented May 12, 2020

@Gaurav0 This looks good! I think we can release a new major version after this as we also removed Node support and get people using it. Worst case people open bugs :)
We can also release a beta version of a new major version to be more on the safe side.
@rwwagner90 Any thoughts?

Alonski
Alonski approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@Alonski Alonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Thanks!

RobbieTheWagner
RobbieTheWagner approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobbieTheWagner
Copy link
Member

@Alonski I think we should update even further if we can, and also drop node 6 support, then we should just release a new major version. No beta is needed, IMO.

@RobbieTheWagner RobbieTheWagner merged commit 328a73f into adopted-ember-addons:master May 12, 2020
@Alonski
Copy link
Member

Alonski commented May 12, 2020

@rwwagner90 Ok lets see how far we can update :)

@Gaurav0 Gaurav0 deleted the update_3_4 branch May 12, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbieTheWagner RobbieTheWagner RobbieTheWagner approved these changes

@Alonski Alonski Alonski approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gaurav0 @Alonski @RobbieTheWagner