Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes #207

Merged
merged 1 commit into from
Jun 3, 2016
Merged

Bug fixes #207

merged 1 commit into from
Jun 3, 2016

Conversation

offirgolan
Copy link
Collaborator

  • null length should error
  • add parentAttribute in errors
  • add .[] dependent key in has-many
  • extend dependents from base validator

@offirgolan
Bug fixes
1322d91 
- null length should error
- add parentAttribute in errors
- add .[] dependent key in has-many
- extend dependents from base validator
@offirgolan offirgolan merged commit 84a87ec into master Jun 3, 2016
offirgolan added a commit that referenced this pull request Jun 3, 2016
@offirgolan
Merge branch 'master' into bug-fixes
5d54933 
* master:
  Released v2.9.1
  Update changelog
  Bug fixes (#207)
@aalimovs
Copy link

aalimovs commented Jun 8, 2016

Null or undefined value in length validator should be invalid

I assume ember-cp-validations follows semver. How is this not a breaking change?

@offirgolan
Copy link
Collaborator Author

@aalimovs that was my mistake. Ill add upgrade notes to the release. Please use allowBlank to allow null or undefined values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@offirgolan @aalimovs