[BugFix] Define CPs and nested CPs in attrs object once per class #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offirgolan
changed the title
offirgolan
changed the title
offirgolan
added a commit
that referenced
this pull request
Oct 2, 2016
* master: (26 commits) chore(package): update ember-code-snippet to version 1.7.0 (#362) Replace blanket with ember-cli-code-coverage (#359) Remove targetObject usage in dummy app (#358) Made some spelling corrections in the documentation (#356) [BUGFIX] Add a check if ember-data exists for isDSManyArray (#354) chore(package): update moment to version 2.15.1 (#353) fix typo in collection validator (#352) chore(package): update ember-cli-moment-shim to version 2.1.0 (#346) chore(package): update moment to version 2.15.0 (#340) chore(package): update ember-cli-jshint to version 2.0.0 (#345) Released v3.0.1 Add polyfill for `Ember.Handlebars.SafeString` (#344) Released v3.0.0 [FEATURE] Add validator type to error messages (#338) Allow for requirejs.has to not be available (#339) Cleanup some attr class logic Released v3.0.0-beta.7 Fix docs Remove examples from readme Remove multiple nested defineProperty per instance of attrs object creation (#333) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, we are using
definePropertyto add CPs and nested object CPs in theinitmethod of the attrs object creation. This is extremely slow and runs on a per instance basis.This PR removes the need for that by creating a tree of nested classes while applying the CPs on their protos. Once the attrs class is created, it instantiates those classes.