Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use weakmap instead of mutating object validation mixin is applied to #634

Merged
merged 1 commit into from
Apr 12, 2019
Merged

fix: use weakmap instead of mutating object validation mixin is applied to #634

merged 1 commit into from
Apr 12, 2019

Conversation

jasonmit
Copy link
Contributor

@jasonmit jasonmit commented Apr 12, 2019 •
edited
Loading

Use weakmap instead of mutating object validation mixin is applied to. Useful for those with buffered proxying logic where this may dirty their record on init.

@offirgolan offirgolan merged commit 5211784 into adopted-ember-addons:master Apr 12, 2019
@jasonmit jasonmit deleted the u/jasonmit/weakmap-validation-count branch April 12, 2019 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offirgolan offirgolan offirgolan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonmit @offirgolan