Fix #316 polymorphic create fragment #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Vincent Molinié <vincentm@forestadmin.com>
# Conflicts: # addon/array/fragment.js # tests/dummy/app/models/component.js # tests/unit/polymorphic_test.js
FragmentArray#type was renamed to modelName FragmentArray#options are no longer used
|
There seems to be a problem still with polymorphic values in fragmentArrays when using const zoo = store.createRecord('zoo', {
star: { $type: 'lion' },
animals: [{ $type: 'lion' }, { $type: 'elephant' }],
});
zoo.star instanceof Lion; // true ✅
zoo.animals.firstObject instanceof Lion; // false ❌
zoo.animals.lastObject instanceof Elephant; // false ❌Edit: resolved by 15fac61 |
dwickern
force-pushed
the
fix-#316-polymorphic-create-fragment
branch
from
d365032 to
576f118
Compare
dwickern
force-pushed
the
fix-#316-polymorphic-create-fragment
branch
from
a00fe7a to
15fac61
Compare
|
@dwickern ready for review? |
|
@knownasilya ready for review 👍 |
knownasilya
added
the
bug
knownasilya
merged commit e005411
into
adopted-ember-addons:master
7 of 11 checks passed
|
@knownasilya any plans to release this fix? |
|
@dwickern released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the merge conflicts from #436 and got it working with the new RecordData implementation.
Fixes #316
Closes #436