Update Ember to 3.24 #698
Merged
Update Ember to 3.24 #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbieTheWagner
force-pushed
the
ember-3.24
branch
from
fef8b6a to
942c5d1
Compare
RobbieTheWagner
force-pushed
the
ember-3.24
branch
from
49b2b09 to
41fd835
Compare
bendemboski
force-pushed
the
ember-3.24
branch
3 times, most recently
from
2571aad to
8ab37eb
Compare
Use a more reliable method of determining if we're running in a yarn project vs. an npm project
bendemboski
force-pushed
the
ember-3.24
branch
from
8ab37eb to
62f9480
Compare
Now that prettier is enabled by default, our blueprint-generated files have the wrong line endings on Windows, so fix that
bendemboski
force-pushed
the
ember-3.24
branch
from
62f9480 to
f440bd8
Compare
bendemboski
approved these changes
Jan 24, 2021
There was a problem hiding this comment.
@rwwagner90 I read through your changes, and they look good. Painful to read because I have a strong distaste for prettier, but I guess that's the way things are going, so I have to get over myself 😄
Have a look at my two commits, and if they look good to you, then merge away!
|
Looks good @bendemboski, thanks so much for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.