Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Mac from tests #699

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Remove Mac from tests #699

merged 1 commit into from
Jan 22, 2021

Conversation

RobbieTheWagner
Copy link
Member

@RobbieTheWagner RobbieTheWagner commented Jan 22, 2021

Mac tests were having some issues, so removing them for now. We should definitely add back in the future, so we are testing on all platforms.

@RobbieTheWagner RobbieTheWagner merged commit 3763fbe into master Jan 22, 2021
@RobbieTheWagner RobbieTheWagner deleted the remove-mac-tests branch January 22, 2021 15:48
@bendemboski
Copy link
Member

@rwwagner90 did you try rerunning CI? It looks like it might just be some kind of transitory error? https://github.com/adopted-ember-addons/ember-electron/runs/1749036285#step:7:73

@RobbieTheWagner
Copy link
Member Author

@bendemboski I wasn't sure, since we didn't test on Mac before. We can definitely add it back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants