Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change vendor.js to app.js in documentation #700

Merged
merged 1 commit into from
Jan 24, 2021

Conversation

bendemboski
Copy link
Member

Because of how blunt broccoli-asset-rev is, the occurences of vendor.js in our documentation get rewritten with the fingerprinted filename vendor-<hash>.js, which is weird and confusing in the generated documentation site. So change to app.js which doesn't match any assets and won't get rewritten (and it just as good for the documentation/example purposes).

Because of how blunt `broccoli-asset-rev` is, the occurences of `vendor.js` in our documentation get rewritten with the fingerprinted filename `vendor-<hash>.js`, which is weird and confusing in the generated documentation site. So change to `app.js` which doesn't match any assets and won't get rewritten (and it just as good for the documentation/example purposes).
@RobbieTheWagner RobbieTheWagner merged commit 4b50190 into master Jan 24, 2021
@RobbieTheWagner RobbieTheWagner deleted the documentation-tweaks branch January 24, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants