Make embroider-compatible #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't use the postprocessTree() hook anymore, so fix the asset URLs by adding a `<base href="..">` element via the `contentFor()` hook, and make testem work by writing a new `<script>` tag with the working `testem.js` URL, leaving the exists one in place harmlessly no-op'ing.
|
@rwwagner90 can you test this in your app? I'm particularly wary of the |
bendemboski
commented
Jan 25, 2021
| // https://ember-electron.js.org/versions/v3.0.0-beta.5/docs/faq/routing-and-asset-loading) | ||
| return [injectScript('shim-test-head.js'), '<base href="..">'].join( | ||
| '\n' | ||
| ); |
There was a problem hiding this comment.
shakes fist at prettier
RobbieTheWagner
approved these changes
Jan 25, 2021
jacobq
pushed a commit
to jacobq/ember-electron
that referenced
this pull request
May 10, 2022
!! CHERRY PICK !! See 8d6080e Make embroider-compatible We can't use the postprocessTree() hook anymore, so fix the asset URLs by adding a `<base href="..">` element via the `contentFor()` hook, and make testem work by writing a new `<script>` tag with the working `testem.js` URL, leaving the exists one in place harmlessly no-op'ing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't use the postprocessTree() hook anymore, so fix the asset URLs by adding a
<base href="..">element via thecontentFor()hook, and make testem work by writing a new<script>tag with the workingtestem.jsURL, leaving the exists one in place harmlessly no-op'ing.