Update ember-modifier to add support for 3.22 modifier capabilities #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SergeAstapov do you mind rebasing when you have a chance? |
|
@lukemelia rebased! However 3.12 tests are failing (which is weird enough considering 3.8 pass). Will look into root cause |
|
@lukemelia had to install Some details can be seen in emberjs/ember-render-modifiers#14 @lukemelia I think this may be included in either v6 or v7. |
leoeuclids
pushed a commit
to leoeuclids/ember-keyboard
that referenced
this pull request
Dec 11, 2023
This moves the `ember-a11y-testing` config into the dummy app's environment file. This prevents the config from being merged with the consuming app's config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes deprecations in recent version of Ember and add support for Ember v4