Fix ember-modifier v3.2 compatibility #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeAstapov
referenced
this pull request
Apr 8, 2022
Follows [`ember-modifier` v4 migration guide](https://github.com/ember-modifier/ember-modifier/blob/v3.2.5/MIGRATIONS.md#function-based-modifiers) to remove deprecations added in v3.2.0 and makes addon future ready.
SergeAstapov
force-pushed
the
ember-modifier-v4-compat
branch
5 times, most recently
from
8d0e031
to
3c9a7e5
Compare
SergeAstapov
force-pushed
the
ember-modifier-v4-compat
branch
from
3c9a7e5
to
112cde0
Compare
Condition about whether to use new or old version of `on-key` modifier class was flipped. Additionally, this adds `useWorkspaces` to ember-try config so that proper version of `ember-modifier` is used across the monorepo. This is needed so that `ember-modifier-X` ember-try scenarios resolve to the same version of `ember-modifier` both in the `test-app` and `addon` workspaces. `ember-classic` scenario should not use `useWorkspaces` flag as only test-app need to get classic flags.
SergeAstapov
force-pushed
the
ember-modifier-v4-compat
branch
from
112cde0
to
66acbb7
Compare
|
@lukemelia if this looks good, could you please release v8.1.1. sorry about the churn. |
|
Thanks @SergeAstapov |
|
Released as 8.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fix for the logic/condition introduced in #617
Condition about whether to use new or old version of
on-keymodifier class was flipped.Additionally, this adds
useWorkspacesto ember-try configso that proper version of
ember-modifieris usedacross the monorepo.
This is needed so that
ember-modifier-Xember-try scenariosresolve to the same version of
ember-modifierboth in thetest-appandaddonworkspaces.ember-classicscenario should not useuseWorkspacesflag as only test-app need to get classic flags.