Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

droppable attribute is not respected. #494

Open
akshay-kr opened this issue Oct 13, 2017 · 0 comments
Open

droppable attribute is not respected. #494

akshay-kr opened this issue Oct 13, 2017 · 0 comments

Comments

@akshay-kr
Copy link
Contributor

akshay-kr commented Oct 13, 2017

Docs mentions that droppable attribute defines Whether the column is a valid drop target..
I tried setting it to false for a column but still it gets displaced by dropping another column on it.

I think we should have a check for droppable attribute after below line,
https://github.com/offirgolan/ember-light-table/blob/master/addon/mixins/draggable-column.js#L116

if(targetColumn.droppable){ 
  //then proceed
}

Created a PR for this #496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant