Fix-Add droppable attribute check on target column before dropping source column #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-alvarez
approved these changes
Oct 18, 2017
|
Thanks for this! Seems like a quite a big woopsie 🤕 |
buschtoens
pushed a commit
that referenced
this pull request
Oct 26, 2017
* feat(custom-icons): base files * fix(column-base): sort icon displayed with sortable:false * feat(dummy): cookbook for custom-sort-icon * loosen ember-one-way-controls version requirement * yarn.lock updates * [BUGFIX release]: Added check for target column is droppable (#496) * [chore]: Update ember-truth-helpers to latest version. (#497) * [BUGFIX release]: Ensure the drop target remains properly identified (#418) * fix(feedback): iconComponent comments, iconComponent test * fix(feedback-v2): iconComponent comments, iconComponent test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
droppableattribute is not respected when dropping source column over target column where the attribute is set to false.Just added a check on this PR for
droppableattribute on target column.Related Issue : #494