Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Add footer scaffolding and move width into style attr #183

Merged
merged 1 commit into from
Sep 23, 2016
Merged

[BUGFIX] Add footer scaffolding and move width into style attr #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions addon/templates/components/lt-foot.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
{{#ember-wormhole to=(concat tableId '_inline_foot') renderInPlace=renderInPlace}}
<table class={{tableClassNames}}>
<tfoot class="lt-foot">
<tr class="lt-scaffolding-row">
{{#each columns as |column|}}
<td style={{html-safe (if column.width (concat 'width: ' column.width))}} class="lt-scaffolding"></td>
{{/each}}
</tr>
{{#if hasBlock}}
{{yield columns}}
{{else}}
Expand Down
4 changes: 2 additions & 2 deletions addon/templates/components/lt-head.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
the td's fail to hold their width. Creating a scaffolding will setup the table columns correctly
--}}
{{#if subColumns.length}}
<tr>
<tr class="lt-scaffolding-row">
{{#each subColumns as |column|}}
<td width={{column.width}} class="lt-scaffolding"></td>
<td style={{html-safe (if column.width (concat 'width: ' column.width))}} class="lt-scaffolding"></td>
{{/each}}
</tr>
{{/if}}
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
"dependencies": {
"ember-cli-babel": "^5.1.6",
"ember-cli-htmlbars": "^1.0.11",
"ember-composable-helpers": "^1.1.2",
"ember-get-config": "0.1.7",
"ember-in-viewport": "2.1.0",
"ember-scrollable": "0.3.2",
Expand Down