Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the drop target remains properly identified for draggable columns #418

Merged
merged 1 commit into from
Oct 18, 2017
Merged

Ensure the drop target remains properly identified for draggable columns #418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions addon/mixins/draggable-column.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,14 @@ export default Ember.Mixin.create({

if (this.get('isDropTarget')) {
e.preventDefault();
/*
NOTE: dragLeave will be triggered by any child elements inside the
column. This code ensures the column being dragged over continues to be
identified as the current drop target
*/
if (!this.get('isDragTarget')) {
this.set('isDragTarget', this.get('column') !== sourceColumn);
}
}
},

Expand Down