Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converts ES6 native classes to ember objects #701

Merged
merged 1 commit into from
Aug 19, 2019
Merged

Converts ES6 native classes to ember objects #701

merged 1 commit into from
Aug 19, 2019

Commits on Aug 19, 2019

  1. [BREAKING] fixes #444 #662 converts ES6 native classes to ember objects 

    This is a breaking change as it converts the new Class() syntax to Class.create().
In addition, the only way I could get these to work was to convert the positional arguments to named args in an options hashes:

`new Table(columns, rows)` => `Table.create(columns: columns, rows: rows)`
`new Row(content, options)` => `Row.create({ content: })`
`new Column(opts)` => `Column.create(opts)`

We’ve had to replace the native constructor methods with emberObject init methods as per the official docs which should also fix #699. As a result we’ve removed the Ember 2.12 ‘hacks’ which shouldn’t be an issue as we’ve bumped ember version minimum version to 2.18.
    @fran-worley
    fran-worley committed Aug 19, 2019
    Configuration menu
    Copy the full SHA
    bf2fcde View commit details
    Browse the repository at this point in the history