Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert dummy app #793

Merged

Conversation

maxwondercorn
Copy link
Collaborator

Still requires ember @classic decorator until addon is converted.

Copy link
Member

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Just one question

tests/dummy/app/components/cookbook/client-side-table.js Outdated Show resolved Hide resolved
@RobbieTheWagner RobbieTheWagner merged commit 546852e into adopted-ember-addons:master Jul 14, 2022
@maxwondercorn maxwondercorn deleted the convert-dummy-app branch July 14, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants