Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert positional params to named params #809

Merged
merged 4 commits into from
Aug 4, 2022
Merged

Convert positional params to named params #809

merged 4 commits into from
Aug 4, 2022

Conversation

maxwondercorn
Copy link
Collaborator

No description provided.

@maxwondercorn maxwondercorn changed the title Convert positional param s Convert positional params to name params Jul 30, 2022
@maxwondercorn maxwondercorn changed the title Convert positional params to name params Convert positional params to named params Jul 30, 2022
@RobbieTheWagner
Copy link
Member

This will be a major breaking change, but I do think it is necessary.

@maxwondercorn
Copy link
Collaborator Author

maxwondercorn commented Aug 4, 2022 •
edited
Loading

Yes, we need this to complete internal conversion to angle brackets. Hopefully for most apps table would be the only change. row, column and maybe others if they are extending components.

I have a somewhat almost complete conversion to native classes once this is merged

@RobbieTheWagner RobbieTheWagner merged commit 8722637 into adopted-ember-addons:master Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbieTheWagner RobbieTheWagner RobbieTheWagner approved these changes

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxwondercorn @RobbieTheWagner