Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mixpanel adapter tracking code #224

Merged
merged 2 commits into from
Aug 25, 2020

Conversation

nselikoff
Copy link
Contributor

No description provided.

@jherdman
Copy link
Contributor

@nselikoff are you interested in making these changes still? If so, do you mind rebasing against master?

@jherdman
Copy link
Contributor

#254 is likely related.

@nselikoff
Copy link
Contributor Author

@jherdman I rebased against master and double checked that the snippet matches the latest from the mixpanel docs. The tests run and the dummy app looks good (though FYI, I had to temporarily change the token to my own to test the dummy app).

Also, I happened to notice that for folks implementing Mixpanel in the EU, there's a different config required: https://developer.mixpanel.com/docs/implement-mixpanel#implementing-mixpanel-in-the-european-union-eu

I'll create a new issue for this if there isn't one already.

@jherdman
Copy link
Contributor

I'll create a new issue for this if there isn't one already.

That'd be great!

@jherdman jherdman merged commit 8af2596 into adopted-ember-addons:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants