fix(metrics service): replace object iterator with Object.values
#374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilest
changed the title
Object.entries
gilest
force-pushed
the
fix/not-iterable-will-destroy
branch
from
8f28d35
to
bb3e800
Compare
gilest
changed the title
Object.entriesObject.values
jherdman
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the _adapters = {}; doesn't support native iteration since it's a plain object.
From MDN:
Fixes #373
Lifecycle test
I've added a very basic acceptance test – which fails before this patch is applied. I think it can be helpful to catch lifecycle bugs like this in the future. Happy to split into a separate PR if necessary.