Remove ember-cp-validations from demo application #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks 👋 I'm back trying to tackle a few of the deprecations. I was just trying to enable ember-cli-deprecation-workflow there and I was drowning in the command line notifications of deprercations with the
VGethelper which I'm pretty sure is coming from ember-cp-validations 🤔 you can see the deprecations in the build log here https://github.com/miguelcobain/ember-paper/runs/5433203392?check_suite_focus=true#step:6:147I suspect this PR will remove all of those deprecations and since ember-cp-validations is not Ember 4 compatible we will need to remove it if we want to get Ember 4 tests to pass 👍