Convert PaperGridList to native class syntax #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
force-pushed
the
grid-list-class
branch
2 times, most recently
from
b4b757c to
5950273
Compare
This was referenced Jul 10, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks 👋 I'm still aiming to remove as many deprecations as I can, and my next target is to try to upgrade the
ember-composability-toolsdependencyBut before I do that I need to convert each of the components that use it to glimmer components. I'm doing that step by step and trying to keep the change as small as possible.
This PR introducesember-classic-decoratorto try to keep the PR diff as small as possible. This was recommended by the lining setup to prevent me from needing to convert allthis.get()andthis.set()calls in this PR (making it harder to follow)I had originally used
ember-classic-decoratorsince that's what the lint message suggested, but it seemed to break in earlier Ember versions so I just dropped it and ignored the lint error (temporarily) 👍 quick reminder that we have a PR to setup the lint-to-the-future dashboard to keep track of these temporary ignores ;) #1215