Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: get rid of deprecation - deprecated-run-loop-and-computed-dot-access #1242

Conversation

wozny1989
Copy link
Contributor

Tasks:

@wozny1989 wozny1989 mentioned this pull request May 29, 2023
4 tasks
@wozny1989 wozny1989 force-pushed the chore/wozny1989/get-rid-of-deprecation-run-loop-dot-access branch from 4fddc46 to ec663f8 Compare May 29, 2023 11:10
Copy link
Collaborator

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🎉

@mansona mansona changed the title chore: get rid of deprecation - Run loop and computed dot access chore: get rid of deprecation - deprecated-run-loop-and-computed-dot-access May 29, 2023
@mansona
Copy link
Collaborator

mansona commented Jun 2, 2023

@wozny1989 did you get a chance to see why tests are failing?

@wozny1989
Copy link
Contributor Author

@mansona should pass now 🤞

@mansona mansona merged commit 0c46798 into adopted-ember-addons:master Jun 6, 2023
@github-actions github-actions bot mentioned this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants