Fixes testing of multiple pikaday inputs #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The removal of jquery changed the test selectors so they no longer checked for visibility. So when selecting a date from the second or greater pikaday input on a page it would not fill out the correct inputs. This has been fixed by returning the first visible element rather than the first element in the dom.
ghost
added
the
|
Thank you for the contribution @john-griffin ! |
ghost
merged commit 
|
Any chance we could get a bug fix release for this? It's preventing us upgrading at the moment as all our tests fail as a result! |
|
@lindyhopchris I can cut one first thing tomorrow if no one else can before then. |
|
@lindyhopchris Released as 2.4.1. |
|
@efx thanks! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removal of jquery #220 changed the test selectors so they no longer checked for visibility. So when selecting a date from the second or greater pikaday input on a page it would not fill out the correct inputs. This has been fixed by returning the first visible element rather than the first element in the dom. Checking
offsetParentappears to be the best way of doing this.I double checked and the test included here was passing in
v2.3.1.