Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Ember 4 and Embroider #532

Merged
merged 25 commits into from
Jan 21, 2022
Merged

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Jan 18, 2022

This is rewrite into modern Ember patterns, and repackaging as a v2 formatted addon. There are semver major changes:

  • minimum supported ember goes up to 3.25
  • minimum supported node goes to 12
  • apps must have ember-auto-import 2
  • moment or moment-shim have become optional peerDependencies. They're optional if you only use the new {{pikaday}} modifier. One or the other must be present if you use the backward-compatible <PikadayInput /> or <PikadayInputless/> components.
  • apps that want Pikaday's default CSS (you probably do) must include them explicitly. This replaces the excludePikadayAssets option. See below.

The <PikadayInput> and <PikadayInputless/> components should have no changes (and all their tests are passing unchanged).

There is also now a modifier to directly invoke Pikaday on an element:

<input {{pikaday value=this.startDate onSelect=this.setStartDate}} />

CSS Handling

None of these components hard-code their CSS, because this addon historically has an option to leave the CSS out. Instead, consuming apps that want the standard CSS should pull it in. For example:

// app/modifiers/pikaday.js
import "ember-pikaday/pikaday.css";
export { default } from "ember-pikaday/modifiers/pikaday";

@ef4
Copy link
Contributor Author

ef4 commented Jan 18, 2022

This PR includes a GitHub Actions setup, you can see it running here: ef4#1

@ef4 ef4 merged commit fff89b6 into adopted-ember-addons:master Jan 21, 2022
@ef4 ef4 added the breaking label Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant