-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for Ember 4 and Embroider #532
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we need it if you use the test-support module.
Due to use of first-class modifiers.
This PR includes a GitHub Actions setup, you can see it running here: ef4#1 |
...when using only the new modifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rewrite into modern Ember patterns, and repackaging as a v2 formatted addon. There are semver major changes:
{{pikaday}}
modifier. One or the other must be present if you use the backward-compatible<PikadayInput />
or<PikadayInputless/>
components.excludePikadayAssets
option. See below.The
<PikadayInput>
and<PikadayInputless/>
components should have no changes (and all their tests are passing unchanged).There is also now a modifier to directly invoke Pikaday on an element:
CSS Handling
None of these components hard-code their CSS, because this addon historically has an option to leave the CSS out. Instead, consuming apps that want the standard CSS should pull it in. For example: