-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated modifier to use new ember-modifier api. #551
Updated modifier to use new ember-modifier api. #551
Conversation
…er dependancy to ^3.2.7 and ^4.0.0
Hmmm, all this ran locally because I have node 19. Looks like would have to update the job runner from node 14 to node 16. Ember modifier doesnt say Node 16 or greater in its docs
But its volta say that
Do we want a separate commit that updates node to 16 or greater? or do it in this PR? Seems that would warrant a major version bump as well |
Any suggestions on how to handle a needed update to node 16? Do in this PR or do as a separate PR? |
All the tests run locally, but I have node 16+ Attempted to update to node 16 here with this PR #552 but no ideas how to resolve the issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this!
Cant merge because the tests failed (node 16). All the tests run locally. |
@MelSumner thanks for the approval, but looks like I dont have the auth to merge. And note, if it is merged, wont build til the CI is upgraded to node 16+. which I tried to do in this PR #552 but no idea what the errors are trying to say. So merging this comes with a requirement. |
What do I need to do to get this merged and released. |
Looks like this could be a duplicate of #540 which never got merged. What can we do about getting one of these merged? @MelSumner approved this, but not sure where to go from here |
I’m so sorry for missing this. I merged the other one, can you rebase? I’ll keep closer watch. |
I am assuming that since you merged #540 this would be unneeded. Will check and close |
540 does the same thing I was doing. Closing this. With it being a V2 addon, no real way of using this til you release |
I just go bit by this while upgrading an old app. Thanks for the tips. |
Expanded ember-modifier dependency to ^3.2.7 and ^4.0.0
Fixes #550