Resolve failing test scenarios #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
reviewed
Jan 26, 2024
package.json
Outdated
| @@ -109,10 +108,10 @@ | |||
| } | |||
| }, | |||
| "engines": { | |||
| "node": ">= 20" | |||
| "node": ">=20.11.0" | |||
| }, | |||
There was a problem hiding this comment.
We should remove the node engine from the package because in the consuming app it doesn't matter what version of node it's using
There was a problem hiding this comment.
Should I even leave the "engines" section in there at all then?
There was a problem hiding this comment.
no we don't need the engines section any more 👍
|
@mansona @knownasilya @ef4 I don't know if I can get farther than this without some help, would y'all take a look at the release/beta/canary failures and LMK what you think? TIA!! |
Merged
MelSumner
force-pushed
the
melsumner/resolve-scenario-issues
branch
from
12096c1 to
09cba40
Compare
|
If there's no objections, I'd like to merge this PR, do a release, and then keep working on the release/beta/canary issues so we can at least have some incremental progress. |
knownasilya
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If merged, this PR tries to resolve some scenarios and tidy up some inconsistencies (spelling errors, dependency versions, instructions, etc).
Currently, I can't seem to get release/beta/canary to work, but the embroider scenario now passing is an improvement