Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest ember #198

Closed
jmar910 opened this issue Nov 14, 2018 · 0 comments
Closed

Upgrade to latest ember #198

jmar910 opened this issue Nov 14, 2018 · 0 comments
Assignees

Comments

@jmar910
Copy link
Contributor

jmar910 commented Nov 14, 2018

There are a few outstanding PRs that can be cleaned up and also ones that work can be lifted from (#187). It might be best to use the work from #187 to get us to ember 3.5, or we can attempt to get to 3.4.2 and then upgrade to 3.5.

I did some research into the failing tests on #187 in ember LTS 2.16 and it seems like it would be beneficial to do #191 and #193 first, rewrite those 2 failing tests to use closure actions and remove usage of target(as opposed to using target and bubbling actions), then do the ember upgrade.

@jmar910 jmar910 self-assigned this Nov 15, 2018
@jmar910 jmar910 mentioned this issue Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant