Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use closure actions for 'onDragStart & onDragStop` drag actions #191

Closed
jmar910 opened this issue Nov 13, 2018 · 1 comment
Closed

Use closure actions for 'onDragStart & onDragStop` drag actions #191

jmar910 opened this issue Nov 13, 2018 · 1 comment
Assignees
@jgwhite

Comments

@jmar910
Copy link
Contributor

jmar910 commented Nov 13, 2018

We can refactor this to use closure actions instead of action bubbling
https://github.com/heroku/ember-sortable#drag-actions
This was referenced Nov 13, 2018
Closed
Closed
raulb added a commit that referenced this issue Nov 15, 2018
@raulb
Remove ember-invoke-action
c4b9e45 
Replaces ember-invoke-action in favor of closure actions.

Co-authored-by: Jamie White <jamie@jgwhite.co.uk>

Fixes #191
@raulb raulb mentioned this issue Nov 15, 2018
Merged
@jgwhite jgwhite self-assigned this Nov 15, 2018
@jgwhite
Copy link
Contributor

jgwhite commented Nov 15, 2018

I’m inclined to leave the code and example as-is. My reasoning is that sendAction works with onDragStart="myAction", onDragStart=(action "myAction"), and onDragStart=(action myAction) so we continue to offer full backwards-compatibility. Though I personally prefer onDragStart=(action myAction), onDragStart=(action "myAction") aligns better with Ember’s guides so I think we should stick with that.

Re-open if you disagree 😅

@jgwhite jgwhite closed this as completed Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgwhite jgwhite

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jgwhite @jmar910