Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve this-property-fallback deprecation #439

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

rmachielse
Copy link
Contributor

This resolves two deprecations related to https://deprecations.emberjs.com/v3.x#toc_this-property-fallback:

DEPRECATION: The direction property path was used in a template for the ember-sortable/templates/components/sortable-group.hbs component without using this. This fallback behavior has been deprecated, all properties must be looked up on this when used in the template: {{this.direction}} [deprecation id: this-property-fallback] See https://deprecations.emberjs.com/v3.x#toc_this-property-fallback for more details.

DEPRECATION: The model property path was used in a template for the ember-sortable/templates/components/sortable-group.hbs component without using this. This fallback behavior has been deprecated, all properties must be looked up on this when used in the template: {{this.model}} [deprecation id: this-property-fallback] See https://deprecations.emberjs.com/v3.x#toc_this-property-fallback for more details.

@rmachielse
Copy link
Contributor Author

@alexlafroscia @ygongdev this simple change removes a lot of deprecation warnings from our app and seems compatible with all supported versions. Any chance on a quick merge & release?

@rmachielse
Copy link
Contributor Author

@alexlafroscia @ygongdev anyone able to have a look at this?

Copy link
Member

@alexlafroscia alexlafroscia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay; there's been a lot going on in my personal life and I'm just coming back to OSS now!

@alexlafroscia alexlafroscia merged commit 16532ff into adopted-ember-addons:master Oct 13, 2021
@rmachielse
Copy link
Contributor Author

No worries at all, appreciate the effort on this and other work! @alexlafroscia

@rmachielse rmachielse deleted the patch-1 branch October 14, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants