Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ember-modifier to 3.2.0 (drop Ember < 3.24) #476

Merged
merged 2 commits into from
May 13, 2022
Merged

Update ember-modifier to 3.2.0 (drop Ember < 3.24) #476

merged 2 commits into from
May 13, 2022

Conversation

BnitoBzh
Copy link
Contributor

@BnitoBzh BnitoBzh commented May 6, 2022

Fix #474

@BnitoBzh
Copy link
Contributor Author

BnitoBzh commented May 9, 2022 •
edited
Loading

someone to merge? I don't think there is a breaking change.

@cah-brian-gantzler
Copy link
Contributor

Its my understand that with 3.2 modifier they are now lazy. So it is possible there could be a breaking change. Its prob best to go with its a breaking change

@cah-brian-gantzler
Copy link
Contributor

Oh he made it opt in to Lazy, thought it was lazy by default. https://github.com/ember-modifier/ember-modifier/blob/master/MIGRATIONS.md#when-is-this-a-breaking-change

So yea, prob not a breaking change

@NullVoxPopuli
Copy link
Contributor

looks good to me -- much easier to read

@NullVoxPopuli NullVoxPopuli merged commit 8aae20c into adopted-ember-addons:master May 13, 2022
@knownasilya knownasilya changed the title Update ember-modifier to 3.2.0 Update ember-modifier to 3.2.0 (drop Ember < 3.24) May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update ember-modifier to 3.2.0
4 participants
@BnitoBzh @cah-brian-gantzler @NullVoxPopuli @knownasilya