when sortable is disabled, scrolling is blocked on ios

[st-h]

I just came across a bug on iOS when sorting is disabled. When the scroll handle is touched, scrolling would suddenly no longer work at all. This is particularly problematic when the handle is the same element as the sortable item. Then the only way to scroll is by touching the background between elements (in case it is visible).

It turned out that this is caused by the css style touch-action: none.

This PR sets touch-action to initial when sorting is disabled, so that the list is scrollable again without issues.

[st-h]

Are there any issues preventing this from being merged?

[NullVoxPopuli]

I don't have an iOS device to test on, personally

[st-h]

@NullVoxPopuli thanks for the information. How do we address this then?

[NullVoxPopuli]

I posted in discord about this pr, hoping to get someone to review soon

[gilest]

Hey @st-h I'm struggling to understand exactly how to test this:

When the scroll handle is touched, scrolling would suddenly no longer work at all.

What exaclty is the scroll handle? Is it a sortable element or part of the iOS UI?

Anyway, I had a go by pausing the test runner here ( within Safari within the iOS Simluator. Here's a recording of what it looks like:

unpatched.mov

patched.mov

With both the patched and unpatched version I couldn't reproduce "scrolling would suddenly no longer work at all" but dragging on the sortable items does not cause any scroll.

Hope this helps 🤷🏻

[st-h]

Sorry about the confusion. This was meant to say sortable-handle. The handle within the sortable element. This add-on sets the style touch-action to none, which disables touch action events. Therefore this also disables scrolling. I had a patched version of the dummy app, which replicated this bug, but I revered that a few weeks ago, not thinking I would need it again. I can try to put something to reproduce together today.

[st-h]

@gilest please give the test-app in https://github.com/st-h/ember-sortable/tree/reproduce-ios-bug a try. The dummy app has a section "scrollable". Please try to touch the handle on the right side and try to scroll the list. All touch events are blocked on the handle. This is a huge issue when the whole scrollable item is a scroll handle. Then this bugs prevents scrolling the entire list. This is caused by setting touch-action to 'none'.

[st-h]

I just tried and the issue also is reproducible in simulator:
https://user-images.githubusercontent.com/5768353/234270544-7e8ac442-b87d-4961-bc8b-dd009c99d11b.mov

[gilest]

Thanks for the repro @st-h I can confirm that this fixes the scroll-blocking issue when testing in iOS simulator.

fixed.mov

[st-h]

@gilest thanks for confirming. Is there anything that keeps us from merging?

[gilest]

@gilest thanks for confirming. Is there anything that keeps us from merging?

Not from my perspective. Will need a maintainer to merge though. @NullVoxPopuli do you have maintainer permission?

[NullVoxPopuli]

Yup. Seems good to me, thanks!