-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow @ember/test-helpers 3 #518
Allow @ember/test-helpers 3 #518
Conversation
4b4290d
to
b4a27c6
Compare
Not sure which pnpm version was used to generate the lockfile. I setup pnpm@7.33.6, instead of the last one 8. It should works now. |
8db39dc
to
e3d9237
Compare
e3d9237
to
bbbefff
Compare
I fixed a small when running tests with @ember/test-helpers v3. Should be good now! |
bbbefff
to
992e983
Compare
Is there is any chance to merge it? |
@francois2metz should it pass in ember-release? |
Rerunning the tests made it pass, and it didn't seem related to your changes. |
Can a release with these changes be published please? I am upgrading my project to Ember 5.4 and I am having to put the following into my package.json file so that an npm install goes through:
|
@ember/test-helpers v3 has been released for a while.