Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ds-error validator for handling nested objects #111

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Fix ds-error validator for handling nested objects #111

merged 1 commit into from
Jan 6, 2022

Conversation

herzzanu
Copy link
Contributor

@herzzanu herzzanu commented Jan 4, 2022

Closes #110

@herzzanu
Fix ds-error validator for handling nested objects
858a73c 
This change broke the ds-error validator behaviour when handling nested objects adopted-ember-addons@f829984
@herzzanu herzzanu mentioned this pull request Jan 4, 2022
Closed
snewcomer
snewcomer approved these changes Jan 6, 2022
View reviewed changes
Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@snewcomer snewcomer merged commit 7382dcb into adopted-ember-addons:master Jan 6, 2022
@snewcomer snewcomer added the bug label Jan 6, 2022
@herzzanu
Copy link
Contributor Author

herzzanu commented Jan 6, 2022

Lovely!

Do we plan to have a patch release with this change? 🙏

@herzzanu herzzanu deleted the nested-ds-error branch January 6, 2022 16:32
@herzzanu herzzanu mentioned this pull request Jan 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snewcomer snewcomer snewcomer approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nested ds-error validations don't work anymore
2 participants
@herzzanu @snewcomer